Changing VLOG from level 1 to 9 for text to be translated.

Changing VLOG from level 1 to 9 for text to be translated.

OWNER rubber stamp, since I only changed a set of VLOG(1) to VLOG(9)...
TBR=thestig

BUG=141691
TEST=Make sure that the text to be translated doesn't show up in vlogs unless you set them level to 9.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151114

[rvargas (doing something else), 2012-08-10 18:41:35]

LGTM.

Note that the ugly log is at translate_helper.cc(163) :)

[MAD, 2012-08-10 19:01:23]

D'Ho!... sorry about that...

All fixed now... CQing... cause... I guess your LGTM still holds since the
change is exactly the same in the other file... Hope it's OK with you... :-)

Thanks!

BYE
MAD...

[commit-bot: I haz the power, 2012-08-10 19:01:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/10831264/4001

[commit-bot: I haz the power, 2012-08-10 19:01:58]

Presubmit check for 10831264-4001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[commit-bot: I haz the power, 2012-08-10 19:05:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/10831264/4001

[rvargas (doing something else), 2012-08-10 19:11:30]

http://codereview.chromium.org/10831264/diff/4001/chrome/renderer/translate_h...
File chrome/renderer/translate_helper.cc (right):

http://codereview.chromium.org/10831264/diff/4001/chrome/renderer/translate_h...
chrome/renderer/translate_helper.cc:163: VLOG(9) << "Detected lang_id: " <<
language << ", from Text:\n" << text
Actually, I would still want to understand why are we dumping the whole text
here and why do we have to do that on the released product (but the bug report
is a better place for that).

I guess 9 is better than 1 so I'm not blocking the commit :)

[commit-bot: I haz the power, 2012-08-10 20:29:02]

Change committed as 151114

[Lei Zhang, 2012-08-17 04:47:12]

lgtm, but please add TBR'd reviewers to the code review in the future.

[MAD, 2012-08-17 13:07:06]

Oupss... sorry... I thought TBR= was doing it automatically...
Won't happen again! ;-)

On Fri, Aug 17, 2012 at 12:47 AM, <thestig@chromium.org> wrote:

> lgtm, but please add TBR'd reviewers to the code review in the future.
>
>
https://chromiumcodereview.**appspot.com/10831264/<https://chromiumcodereview...
>