Only compute LocationBarView::AvailableWidth as needed.

Only compute LocationBarView::AvailableWidth as needed.

NOTE: THIS IS NOT A CRASH FIX!!! It's only an adjustment to reduce unnecessary work in potentially crashy code paths :-/

BUG=141702
TEST=no location bar layout regressions; fewer crashes?


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151118

[msw, 2012-08-10 01:26:13]

Hey Scott, please take a look at this small CL; thanks!

[Alexei Svitkine (slow), 2012-08-10 15:31:52]

https://chromiumcodereview.appspot.com/10831253/diff/3002/chrome/browser/ui/v...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://chromiumcodereview.appspot.com/10831253/diff/3002/chrome/browser/ui/v...
chrome/browser/ui/views/location_bar/location_bar_view.cc:695: const int
kMaxEditWidth = location_entry_->GetMaxEditWidth(entry_width);
This is not the correct naming convention to use here. Only compile-time
constants (i.e. where the result doesn't depend on current state) should use the
kConstant naming scheme.

[sky, 2012-08-10 15:36:02]

LGTM once you fix the name

[msw, 2012-08-10 15:38:07]

On 2012/08/10 15:31:52, Alexei Svitkine wrote:
>
https://chromiumcodereview.appspot.com/10831253/diff/3002/chrome/browser/ui/v...
> File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10831253/diff/3002/chrome/browser/ui/v...
> chrome/browser/ui/views/location_bar/location_bar_view.cc:695: const int
> kMaxEditWidth = location_entry_->GetMaxEditWidth(entry_width);
> This is not the correct naming convention to use here. Only compile-time
> constants (i.e. where the result doesn't depend on current state) should use
the
> kConstant naming scheme.

That's what I thought too, but lines 618-627 had me doubting my sanity; i'll fix
it up.

[msw, 2012-08-10 15:49:21]

Please take another look; thanks.

https://chromiumcodereview.appspot.com/10831253/diff/3002/chrome/browser/ui/v...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://chromiumcodereview.appspot.com/10831253/diff/3002/chrome/browser/ui/v...
chrome/browser/ui/views/location_bar/location_bar_view.cc:695: const int
kMaxEditWidth = location_entry_->GetMaxEditWidth(entry_width);
On 2012/08/10 15:31:52, Alexei Svitkine wrote:
> This is not the correct naming convention to use here. Only compile-time
> constants (i.e. where the result doesn't depend on current state) should use
the
> kConstant naming scheme.

Done.

[msw, 2012-08-10 15:49:45]

doh, missed sky's note, landing.

[commit-bot: I haz the power, 2012-08-10 15:50:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10831253/10002

[Alexei Svitkine (slow), 2012-08-10 16:37:52]

LGTM

[commit-bot: I haz the power, 2012-08-10 18:48:32]

Try job failure for 10831253-10002 (retry) on win_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-10 19:11:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10831253/10002

[commit-bot: I haz the power, 2012-08-10 20:37:01]

Change committed as 151118