Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10831249: Clean up ports allocated by perf windows tests on CNS external server. (Closed)

Created:
8 years, 4 months ago by shadi
Modified:
8 years, 4 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, dennis_jeffrey, feature-media-reviews_chromium.org, anantha, dyu1, Nirnimesh
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Clean up ports allocated by perf windows tests on CNS external server. BUG=141537 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151959

Patch Set 1 : #

Patch Set 2 : Make external server default for Lin and Win #

Total comments: 2

Patch Set 3 : Add USE_LOCAL_CNS env check #

Total comments: 2

Patch Set 4 : Making code shorter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M chrome/test/functional/media/cns_test_base.py View 1 2 3 6 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
shadi
Dale, can you PTAL?
8 years, 4 months ago (2012-08-13 20:55:12 UTC) #1
DaleCurtis
lgtm, sorry for the delay, for some reason I thought this was a much bigger ...
8 years, 4 months ago (2012-08-15 20:24:43 UTC) #2
shadi
Dale, can you PTAL again? This change makes the external CNS server default for all ...
8 years, 4 months ago (2012-08-15 23:56:24 UTC) #3
DaleCurtis
https://chromiumcodereview.appspot.com/10831249/diff/5001/chrome/test/functional/media/cns_test_base.py File chrome/test/functional/media/cns_test_base.py (right): https://chromiumcodereview.appspot.com/10831249/diff/5001/chrome/test/functional/media/cns_test_base.py#newcode48 chrome/test/functional/media/cns_test_base.py:48: USE_EXTERNAL_SERVER = False Can we make this a command ...
8 years, 4 months ago (2012-08-16 00:15:58 UTC) #4
shadi
https://chromiumcodereview.appspot.com/10831249/diff/5001/chrome/test/functional/media/cns_test_base.py File chrome/test/functional/media/cns_test_base.py (right): https://chromiumcodereview.appspot.com/10831249/diff/5001/chrome/test/functional/media/cns_test_base.py#newcode48 chrome/test/functional/media/cns_test_base.py:48: USE_EXTERNAL_SERVER = False On 2012/08/16 00:15:58, DaleCurtis wrote: > ...
8 years, 4 months ago (2012-08-16 19:49:27 UTC) #5
DaleCurtis
lgtm https://chromiumcodereview.appspot.com/10831249/diff/6002/chrome/test/functional/media/cns_test_base.py File chrome/test/functional/media/cns_test_base.py (right): https://chromiumcodereview.appspot.com/10831249/diff/6002/chrome/test/functional/media/cns_test_base.py#newcode49 chrome/test/functional/media/cns_test_base.py:49: USE_LOCAL_CNS = False USE_LOCAL_CNS = ('win' not in ...
8 years, 4 months ago (2012-08-16 19:54:59 UTC) #6
shadi
s/or/and right? https://chromiumcodereview.appspot.com/10831249/diff/6002/chrome/test/functional/media/cns_test_base.py File chrome/test/functional/media/cns_test_base.py (right): https://chromiumcodereview.appspot.com/10831249/diff/6002/chrome/test/functional/media/cns_test_base.py#newcode49 chrome/test/functional/media/cns_test_base.py:49: USE_LOCAL_CNS = False On 2012/08/16 19:54:59, DaleCurtis ...
8 years, 4 months ago (2012-08-16 20:27:03 UTC) #7
DaleCurtis
yup, lgtm
8 years, 4 months ago (2012-08-16 20:33:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/10831249/5
8 years, 4 months ago (2012-08-16 20:34:59 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 20:37:10 UTC) #10 
Change committed as 151959

Powered by Google App Engine
This is Rietveld 408576698