Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 10831242: Trybots need to opt-in win_aura when aura files are changed (Closed)

Created:
8 years, 4 months ago by Emmanuel Saint-loubert-Bié
Modified:
8 years, 3 months ago
Reviewers:
cmp, Peter Mayo, sky
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Over the last week (or so) a couple of CLs had to be reverted because developers had not tested win_aura, specifically: 1. The default trybot rules don't include win_aura in enough cases 2. The CQ did not build win_aura BUG=141701 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150950

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M PRESUBMIT.py View 1 chunk +6 lines, -3 lines 0 comments Download
M ash/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/default_100_percent/ash/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/default_100_percent/aura/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/default_200_percent/ash/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/resources/default_200_percent/aura/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Emmanuel Saint-loubert-Bié
Chase, Peter. Hopefully this will eliminate some of the avoidable tree breakages. (the next step ...
8 years, 4 months ago (2012-08-09 20:52:41 UTC) #1
Peter Mayo
LGTM In the last little while this would have resulted in 50% more load on ...
8 years, 4 months ago (2012-08-09 23:28:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/10831242/4002
8 years, 4 months ago (2012-08-10 00:08:09 UTC) #3
commit-bot: I haz the power
Presubmit check for 10831242-4002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-10 00:08:12 UTC) #4
cmp
lgtm we don't have automated systems (yet) to detect the overload error condition (too many ...
8 years, 4 months ago (2012-08-10 02:17:07 UTC) #5
Peter Mayo
Ping - please submit again.
8 years, 3 months ago (2012-09-07 15:27:36 UTC) #6
Peter Mayo
Can we get an OWNERS OK?
8 years, 3 months ago (2012-09-07 15:28:30 UTC) #7
sky
8 years, 3 months ago (2012-09-07 16:18:20 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld 408576698