Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 10831234: Clean-up inline members of nested classes (ui/) (Closed)

Created:
8 years, 4 months ago by hans
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Clean-up inline members of nested classes (ui/) Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -33 lines) Patch
M ui/views/controls/menu/menu.h View 3 chunks +11 lines, -33 lines 0 comments Download
M ui/views/controls/menu/menu.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hans
8 years, 4 months ago (2012-08-09 13:59:34 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-09 16:10:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10831234/1
8 years, 4 months ago (2012-08-09 17:54:19 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 20:26:02 UTC) #4
Change committed as 150877

Powered by Google App Engine
This is Rietveld 408576698