Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10831230: Small ShellWindowViews cleanup. (Closed)

Created:
8 years, 4 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 4 months ago
Reviewers:
jeremya, jianli
CC:
chromium-reviews, jeremya+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, tfarina, Ben Goodger (Google)
Visibility:
Public.

Description

Small ShellWindowViews cleanup. Fix reference to WebContentsDelegate and make the entire ShellWindow implementation private. R=jianli@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/ui/views/extensions/shell_window_views.h View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mihai Parparita -not on Chrome
8 years, 4 months ago (2012-08-09 05:03:12 UTC) #1
jeremya
This probably collides with http://codereview.chromium.org/10825240/
8 years, 4 months ago (2012-08-09 05:33:29 UTC) #2
jeremya
On 2012/08/09 05:33:29, jeremya wrote: > This probably collides with http://codereview.chromium.org/10825240/ (... which is a ...
8 years, 4 months ago (2012-08-09 05:34:05 UTC) #3
jianli
8 years, 4 months ago (2012-08-09 18:00:06 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698