Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 10831227: Make jars build from a single ant .xml template (Closed)

Created:
8 years, 4 months ago by cjhopman
Modified:
8 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright (departed), jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, peter+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@ant_aidl
Visibility:
Public.

Description

Make jars build from a single ant .xml template The ant build files for each of the jars that we create consisted of only fairly straightforward boilerplate. With the recent changes to java.gypi and java_aidl.gypi we can now build these correctly from a single .xml with GYP passing in defines for the minor differences. BUG=136756 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151334

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -215 lines) Patch
D base/android/java/base.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D base/android/javatests/base_javatests.xml View 1 chunk +0 lines, -52 lines 0 comments Download
M build/android/ant/chromium-jars.xml View 3 chunks +25 lines, -15 lines 0 comments Download
M build/java.gypi View 2 chunks +3 lines, -2 lines 1 comment Download
D chrome/android/java/chrome.xml View 1 chunk +0 lines, -19 lines 0 comments Download
D content/public/android/java/content.xml View 1 chunk +0 lines, -24 lines 0 comments Download
D content/public/android/javatests/content_javatests.xml View 1 chunk +0 lines, -55 lines 0 comments Download
D media/base/android/java/media.xml View 1 chunk +0 lines, -17 lines 0 comments Download
D net/android/java/net.xml View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
cjhopman
8 years, 4 months ago (2012-08-09 00:17:37 UTC) #1
nilesh
On 2012/08/09 00:17:37, cjhopman wrote: LGTM
8 years, 4 months ago (2012-08-09 17:11:38 UTC) #2
Yaron
http://codereview.chromium.org/10831227/diff/1/build/java.gypi File build/java.gypi (right): http://codereview.chromium.org/10831227/diff/1/build/java.gypi#newcode64 build/java.gypi:64: '-Dbasedir=<(java_in_dir)', Where is this used?
8 years, 4 months ago (2012-08-09 17:49:36 UTC) #3
Yaron
lgtm (used elsewhere in ant configs as discussed offline)
8 years, 4 months ago (2012-08-09 17:51:09 UTC) #4
cjhopman
brettw: base/ chrome/ content/ rsleevi: net/
8 years, 4 months ago (2012-08-09 22:37:35 UTC) #5
Ryan Sleevi
net/ lgtm. Nice work!
8 years, 4 months ago (2012-08-10 02:07:42 UTC) #6
brettw
lgtm
8 years, 4 months ago (2012-08-10 18:15:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10831227/1
8 years, 4 months ago (2012-08-13 18:37:52 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 20:17:29 UTC) #9
Change committed as 151334

Powered by Google App Engine
This is Rietveld 408576698