Use ClipboardFilter in ClientSession auth & disable-input blocking.

Use ClipboardFilter in ClientSession to implement auth & disable-input blocking.

This removes the need for ClientSession to implement ClipboardStub
and proxy clipboard events itself.

BUG=118511
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152281

[Wez, 2012-08-09 23:55:20]

PTAL

[simonmorris, 2012-08-10 00:41:54]

lgtm

The chains of filters are now a little hard to follow. It would be easier if it
were possible to enable/disable the filters separately from setting their output
stub. Then most filters' stubs could be set once, all in the same part of the
code, and enabling or disabling them would just involve a boolean.

[Wez, 2012-08-13 17:09:22]

On 2012/08/10 00:41:54, simonmorris wrote:
> lgtm
> 
> The chains of filters are now a little hard to follow. It would be easier if
it
> were possible to enable/disable the filters separately from setting their
output
> stub. Then most filters' stubs could be set once, all in the same part of the
> code, and enabling or disabling them would just involve a boolean.

Yes, I think that's a good idea; will follow-up with a CL for that.

[commit-bot: I haz the power, 2012-08-13 17:10:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10831223/1

[commit-bot: I haz the power, 2012-08-13 17:10:19]

Failed to apply patch for remoting/host/client_session.h:
While running patch -p1 --forward --force;
patching file remoting/host/client_session.h
Hunk #1 succeeded at 12 with fuzz 1.
Hunk #2 FAILED at 29.
Hunk #3 succeeded at 75 (offset 1 line).
Hunk #4 succeeded at 149 (offset 3 lines).
Hunk #5 succeeded at 164 (offset 3 lines).
1 out of 5 hunks FAILED -- saving rejects to file
remoting/host/client_session.h.rej

[commit-bot: I haz the power, 2012-08-14 01:13:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10831223/4002

[commit-bot: I haz the power, 2012-08-14 01:35:00]

Try job failure for 10831223-4002 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Wez, 2012-08-14 18:00:17]

Since ClientSession no longer provides InjectClipboardEvent(), I've exposed the
stubs set on ConnectionToClient by the ClientSession and updated the
ClientSession unit-tests to route events through them.

PTAL!

[simonmorris, 2012-08-16 01:02:42]

lgtm

http://codereview.chromium.org/10831223/diff/10004/remoting/host/client_sessi...
File remoting/host/client_session_unittest.cc (right):

http://codereview.chromium.org/10831223/diff/10004/remoting/host/client_sessi...
remoting/host/client_session_unittest.cc:76: // ClientSession owns |connection_|
but tests it to inject events.
"uses it to inject test events"? Or something else?

[Wez, 2012-08-18 00:26:57]

FYI

http://codereview.chromium.org/10831223/diff/10004/remoting/host/client_sessi...
File remoting/host/client_session_unittest.cc (right):

http://codereview.chromium.org/10831223/diff/10004/remoting/host/client_sessi...
remoting/host/client_session_unittest.cc:76: // ClientSession owns |connection_|
but tests it to inject events.
On 2012/08/16 01:02:42, simonmorris wrote:
> "uses it to inject test events"? Or something else?

Done.

[commit-bot: I haz the power, 2012-08-18 00:49:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10831223/7

[commit-bot: I haz the power, 2012-08-18 02:32:23]

Try job failure for 10831223-7 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-18 21:03:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10831223/7

[commit-bot: I haz the power, 2012-08-18 23:29:36]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2012-08-19 03:18:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10831223/7

[commit-bot: I haz the power, 2012-08-19 06:54:24]

Change committed as 152281