Issue 10831219: roll clang 159409:161353

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831219: roll clang 159409:161353 (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
hans

CC:
chromium-reviews, fischman+watch_chromium.org, glotov+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

roll clang 159409:161353 * Lets -Wunused-private-field find more stuff * Fixes an ASan problem on precise * Improves the plugin's handling of inner classes (off by default, can be enabled with |-Xclang -plugin-arg-find-bad-constructs -Xclang check-inner-classes|) * Makes addr2line much faster on linux * Fix for crash we saw on the valgrind bots after the last roll attempt * The plugin now ignores cc/ by default BUG=139346, 139912 TBR=hans Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150647

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/clang/scripts/update.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

8 years, 4 months ago (2012-08-10 17:57:46 UTC) #3

On Thu, Aug 9, 2012 at 2:21 AM,  <hans@chromium.org> wrote:
> wohoo!

(For posterity, this broke mac asan: http://crbug.com/141532 But we're
keeping the roll, and reverted it locally on just that bot.)

>
> https://chromiumcodereview.appspot.com/10831219/

Expand Messages | Collapse Messages