Issue 10831217: Fix leaks in MediaGalleriesPreferencesTest.*

Issue 10831217: Fix leaks in MediaGalleriesPreferencesTest.* (Closed)

Created:
8 years, 4 months ago by vandebo (ex-Chrome)

Modified:
8 years, 4 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix leaks in MediaGalleriesPreferencesTest.* BUG=141322 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150711

Patch Set 3 : Address comment #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -27 lines)			Patch
M	chrome/browser/media_gallery/media_galleries_preferences_unittest.cc	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

http://codereview.chromium.org/10831217/diff/2001/chrome/browser/media_gallery/media_galleries_preferences_unittest.cc File chrome/browser/media_gallery/media_galleries_preferences_unittest.cc (right): http://codereview.chromium.org/10831217/diff/2001/chrome/browser/media_gallery/media_galleries_preferences_unittest.cc#newcode49 chrome/browser/media_gallery/media_galleries_preferences_unittest.cc:49: // TestExtensionSystem uses delete soon, so we need to ...

8 years, 4 months ago (2012-08-09 00:59:29 UTC) #1

Lei Zhang

lgtm http://codereview.chromium.org/10831217/diff/2001/chrome/browser/media_gallery/media_galleries_preferences_unittest.cc File chrome/browser/media_gallery/media_galleries_preferences_unittest.cc (right): http://codereview.chromium.org/10831217/diff/2001/chrome/browser/media_gallery/media_galleries_preferences_unittest.cc#newcode49 chrome/browser/media_gallery/media_galleries_preferences_unittest.cc:49: // TestExtensionSystem uses delete soon, so we need ...

8 years, 4 months ago (2012-08-09 01:03:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10831217/4

8 years, 4 months ago (2012-08-09 01:09:48 UTC) #3

Change committed as 150711

Expand Messages | Collapse Messages