media/base/pipeline.cc - Issue 10831214: Fix Pipeline to properly handle errors during initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/pipeline.cc

Issue 10831214: Fix Pipeline to properly handle errors during initialization. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address CR comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/pipeline.cc

diff --git a/media/base/pipeline.cc b/media/base/pipeline.cc

index 85ec3e8f5e9070e3e935e3c1f9985a8b0bb6fdb1..6fda59d2901b20fa6f19f37f2bfd2a53397aafd3 100644

--- a/media/base/pipeline.cc

+++ b/media/base/pipeline.cc

@@ -621,6 +621,7 @@ void Pipeline::InitializeTask(PipelineStatus last_stage_status) {

state_ = kInitAudioRenderer;

} else {

SetError(last_stage_status);

+ return;

}

« no previous file with comments | « no previous file | media/base/pipeline_unittest.cc » ('j') | no next file with comments »