Fix Pipeline to properly handle errors during initialization.

Fix Pipeline to properly handle errors during initialization.


BUG=None
TESTS=PipelineTest.InitFailure_XXX

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150636

[scherkus (not reviewing), 2012-08-08 21:15:02]

LGMT w/ nits + q

http://codereview.chromium.org/10831214/diff/1/media/base/pipeline.cc
File media/base/pipeline.cc (right):

http://codereview.chromium.org/10831214/diff/1/media/base/pipeline.cc#newcode624
media/base/pipeline.cc:624: return;
ha!

http://codereview.chromium.org/10831214/diff/1/media/base/pipeline_unittest.cc
File media/base/pipeline_unittest.cc (right):

http://codereview.chromium.org/10831214/diff/1/media/base/pipeline_unittest.c...
media/base/pipeline_unittest.cc:139: if (expect_set_playback_rate)
instead of a bool, can this block can get moves to InitializePipeline when
start_status == PIPELINE_OK?

AFAIK it only gets called if everything gets initialized w/o error

http://codereview.chromium.org/10831214/diff/1/media/base/pipeline_unittest.c...
media/base/pipeline_unittest.cc:221: EXPECT_CALL(*mocks_->audio_renderer(),
SetPlaybackRate(0.0f));
ditto (move to InitializePipeline when start_status == PIPELINE_OK)

http://codereview.chromium.org/10831214/diff/1/media/base/pipeline_unittest.c...
media/base/pipeline_unittest.cc:1005: 
remove extra blank line

[acolwell GONE FROM CHROMIUM, 2012-08-08 21:40:59]

https://chromiumcodereview.appspot.com/10831214/diff/1/media/base/pipeline_un...
File media/base/pipeline_unittest.cc (right):

https://chromiumcodereview.appspot.com/10831214/diff/1/media/base/pipeline_un...
media/base/pipeline_unittest.cc:139: if (expect_set_playback_rate)
On 2012/08/08 21:15:02, scherkus wrote:
> instead of a bool, can this block can get moves to InitializePipeline when
> start_status == PIPELINE_OK?
> 
> AFAIK it only gets called if everything gets initialized w/o error
Yes it can. Done.

https://chromiumcodereview.appspot.com/10831214/diff/1/media/base/pipeline_un...
media/base/pipeline_unittest.cc:221: EXPECT_CALL(*mocks_->audio_renderer(),
SetPlaybackRate(0.0f));
On 2012/08/08 21:15:02, scherkus wrote:
> ditto (move to InitializePipeline when start_status == PIPELINE_OK)

Done.

https://chromiumcodereview.appspot.com/10831214/diff/1/media/base/pipeline_un...
media/base/pipeline_unittest.cc:1005: 
On 2012/08/08 21:15:02, scherkus wrote:
> remove extra blank line

Done.

[commit-bot: I haz the power, 2012-08-08 21:41:59]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[scherkus (not reviewing), 2012-08-08 21:57:38]

lgtm

[commit-bot: I haz the power, 2012-08-08 22:14:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/10831214/5001

[commit-bot: I haz the power, 2012-08-08 22:59:56]

Try job failure for 10831214-5001 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...