Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 10831208: Bring ROTATE_WINDOWS out of debug, again. (Closed)

Created:
8 years, 4 months ago by Jun Mukai
Modified:
8 years, 4 months ago
Reviewers:
mazda, Nico, Daniel Erat
CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Bring ROTATE_WINDOWS out of debug, again. Actually this feature is described in the "keyboard shortcut" section in GSG, so it's expected to work in production too. See crbug.com/128436 for the details. BUG=128436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150757

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ash/accelerators/accelerator_table.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jun Mukai
8 years, 4 months ago (2012-08-08 08:10:17 UTC) #1
mazda
LGTM It was hidden under the flag in http://crrev.com/143054. I'm not 100% sure it was ...
8 years, 4 months ago (2012-08-08 08:56:26 UTC) #2
Jun Mukai
On 2012/08/08 08:56:26, mazda wrote: > LGTM > > It was hidden under the flag ...
8 years, 4 months ago (2012-08-08 09:05:04 UTC) #3
Daniel Erat
lgtm
8 years, 4 months ago (2012-08-08 14:58:38 UTC) #4
Nico
8 years, 4 months ago (2012-08-08 15:07:45 UTC) #5
That wasn't intentional. LGTM.

Powered by Google App Engine
This is Rietveld 408576698