Issue 10831194: Add permission checking to the presumit checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831194: Add permission checking to the presumit checks. (Closed)

Created:
8 years, 4 months ago by csharp

Modified:
7 years, 1 month ago

Reviewers:
Lei Zhang, Nicolas Sylvain, nsylvain

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add permission checking to the presumit checks. BUG=71975 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150557

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -41 lines)			Patch
	M	PRESUBMIT.py	View		3 chunks	+18 lines, -0 lines	0 comments	Download
	M	tools/checkperms/checkperms.py	View		4 chunks	+70 lines, -41 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nsylvain

LGTM, although you might want to check with the owner of checkperm.py

8 years, 4 months ago (2012-08-07 17:15:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10831194/1

8 years, 4 months ago (2012-08-08 13:47:19 UTC) #3

Lei Zhang

7 years, 1 month ago (2013-11-08 00:15:11 UTC) #5

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/10831194/diff/1/tools/checkperms/check...
File tools/checkperms/checkperms.py (right):

https://chromiumcodereview.appspot.com/10831194/diff/1/tools/checkperms/check...
tools/checkperms/checkperms.py:282: if must_be_executable(full_path):
And this is wrong because must_be_executable() takes a rel_path. Fix is on the
way.

Expand Messages | Collapse Messages