Issue 10831186: Make ThumbnailGenerator::AskForSnapshot support high DPI.

Issue 10831186: Make ThumbnailGenerator::AskForSnapshot support high DPI. (Closed)

Created:
8 years, 4 months ago by mazda

Modified:
8 years, 4 months ago

Reviewers:
brettw, oshima

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make ThumbnailGenerator::AskForSnapshot support high DPI. BUG=125043 TEST=Manuall check a snapshot is sent in appropriate size. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150457

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : address comments #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : rebase #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	chrome/browser/tab_contents/thumbnail_generator.cc	View	1 2 3 4 5	2 chunks	+5 lines, -1 line	0 comments	Download
	M	content/renderer/render_widget.cc	View	1 2 3 4 5	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

oshima

lgtm with one request. http://codereview.chromium.org/10831186/diff/2001/chrome/browser/tab_contents/thumbnail_generator.cc File chrome/browser/tab_contents/thumbnail_generator.cc (right): http://codereview.chromium.org/10831186/diff/2001/chrome/browser/tab_contents/thumbnail_generator.cc#newcode224 chrome/browser/tab_contents/thumbnail_generator.cc:224: gfx::Size desired_pixel_size = desired_size.Scale(scale_factor); I ...

8 years, 4 months ago (2012-08-07 03:22:20 UTC) #2

mazda

Thank you for the review. http://codereview.chromium.org/10831186/diff/2001/chrome/browser/tab_contents/thumbnail_generator.cc File chrome/browser/tab_contents/thumbnail_generator.cc (right): http://codereview.chromium.org/10831186/diff/2001/chrome/browser/tab_contents/thumbnail_generator.cc#newcode224 chrome/browser/tab_contents/thumbnail_generator.cc:224: gfx::Size desired_pixel_size = desired_size.Scale(scale_factor); ...

8 years, 4 months ago (2012-08-07 03:55:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10831186/10002

8 years, 4 months ago (2012-08-07 21:21:32 UTC) #6

Change committed as 150457

Expand Messages | Collapse Messages