Make CreateArrayComp a call by using explicit push-argument instructions.

vm/intermediate_language_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 1005 matching lines @@
   compiler->GenerateInstanceOf(cid(),
                                token_pos(),
                                try_index(),
                                type(),
                                negate_result());
   ASSERT(locs()->out().reg() == EAX);
 }
 
 
 LocationSummary* CreateArrayComp::MakeLocationSummary() const {
-  // TODO(regis): The elements of the array could be considered as arguments to
-  // CreateArrayComp, thereby making CreateArrayComp a call.
-  // For VerifyCallComputation to work, CreateArrayComp would need an
-  // ArgumentCount getter and an ArgumentAt getter.
-  const intptr_t kNumInputs = 1;
-  const intptr_t kNumTemps = 1;
-  LocationSummary* locs =
-      new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
-  locs->set_in(0, Location::RegisterLocation(ECX));
-  locs->set_temp(0, Location::RegisterLocation(EDX));
-  locs->set_out(Location::RegisterLocation(EAX));
-  return locs;
+  return MakeCallSummary();
 }
 
 
 void CreateArrayComp::EmitNativeCode(FlowGraphCompiler* compiler) {
-  Register temp_reg = locs()->temp(0).reg();
-  Register result_reg = locs()->out().reg();
-
+  // TODO(fschneider): Support call-instructions that take inputs in registers.
   // Allocate the array.  EDX = length, ECX = element type.
-  ASSERT(temp_reg == EDX);
-  ASSERT(locs()->in(0).reg() == ECX);
-  __ movl(temp_reg,  Immediate(Smi::RawValue(ElementCount())));
+  __ popl(ECX);
+  __ movl(EDX,  Immediate(Smi::RawValue(ElementCount())));
   compiler->GenerateCall(token_pos(),
                          try_index(),
                          &StubCode::AllocateArrayLabel(),
                          PcDescriptors::kOther);
-  ASSERT(result_reg == EAX);
+  ASSERT(locs()->out().reg() == EAX);
 
   // Pop the element values from the stack into the array.
-  __ leal(temp_reg, FieldAddress(result_reg, Array::data_offset()));
+  __ leal(EDX, FieldAddress(EAX, Array::data_offset()));
   for (int i = ElementCount() - 1; i >= 0; --i) {
     ASSERT(ElementAt(i)->IsUse());
-    __ popl(Address(temp_reg, i * kWordSize));
+    __ popl(Address(EDX, i * kWordSize));
   }
 }
 
 
 LocationSummary*
     AllocateObjectWithBoundsCheckComp::MakeLocationSummary() const {
   const intptr_t kNumInputs = 2;
   const intptr_t kNumTemps = 0;
   LocationSummary* locs =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
@@ skipping 1040 matching lines @@
   ASSERT(locs()->out().reg() == EAX);
   __ CompareObject(locs()->out().reg(), compiler->bool_true());
   EmitBranchOnCondition(compiler, branch_condition);
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64