 Chromium Code Reviews
 Chromium Code Reviews Issue 10831172:
  Introduced TypeFeedbackId and BailoutId types.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
    
  
    Issue 10831172:
  Introduced TypeFeedbackId and BailoutId types.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge| Index: src/type-info.h | 
| diff --git a/src/type-info.h b/src/type-info.h | 
| index fbd4d2a651fc3ef414e7f1e7c5c2ee3cf77ad888..1a68c11b30d9c51ad21b26c088126977ddd537bd 100644 | 
| --- a/src/type-info.h | 
| +++ b/src/type-info.h | 
| @@ -242,8 +242,8 @@ class TypeFeedbackOracle: public ZoneObject { | 
| bool LoadIsMonomorphicNormal(Property* expr); | 
| bool LoadIsUninitialized(Property* expr); | 
| bool LoadIsMegamorphicWithTypeInfo(Property* expr); | 
| - bool StoreIsMonomorphicNormal(Expression* expr); | 
| - bool StoreIsMegamorphicWithTypeInfo(Expression* expr); | 
| + bool StoreIsMonomorphicNormal(TypeFeedbackId id); | 
| 
Michael Starzinger
2012/08/06 13:03:41
Let's rename "id" to "ast_id" for consistency.
 
Sven Panne
2012/08/06 14:08:40
Done.
 | 
| + bool StoreIsMegamorphicWithTypeInfo(TypeFeedbackId id); | 
| bool CallIsMonomorphic(Call* expr); | 
| bool CallNewIsMonomorphic(CallNew* expr); | 
| bool ObjectLiteralStoreIsMonomorphic(ObjectLiteral::Property* prop); | 
| @@ -251,7 +251,7 @@ class TypeFeedbackOracle: public ZoneObject { | 
| bool IsForInFastCase(ForInStatement* expr); | 
| Handle<Map> LoadMonomorphicReceiverType(Property* expr); | 
| - Handle<Map> StoreMonomorphicReceiverType(Expression* expr); | 
| + Handle<Map> StoreMonomorphicReceiverType(TypeFeedbackId id); | 
| void LoadReceiverTypes(Property* expr, | 
| Handle<String> name, | 
| @@ -263,7 +263,7 @@ class TypeFeedbackOracle: public ZoneObject { | 
| Handle<String> name, | 
| CallKind call_kind, | 
| SmallMapList* types); | 
| - void CollectKeyedReceiverTypes(unsigned ast_id, | 
| + void CollectKeyedReceiverTypes(TypeFeedbackId ast_id, | 
| SmallMapList* types); | 
| static bool CanRetainOtherContext(Map* map, Context* global_context); | 
| @@ -283,7 +283,7 @@ class TypeFeedbackOracle: public ZoneObject { | 
| // TODO(1571) We can't use ToBooleanStub::Types as the return value because | 
| // of various cylces in our headers. Death to tons of implementations in | 
| // headers!! :-P | 
| - byte ToBooleanTypes(unsigned ast_id); | 
| + byte ToBooleanTypes(TypeFeedbackId ast_id); | 
| // Get type information for arithmetic operations and compares. | 
| TypeInfo UnaryType(UnaryOperation* expr); | 
| @@ -297,12 +297,12 @@ class TypeFeedbackOracle: public ZoneObject { | 
| Zone* zone() const { return zone_; } | 
| private: | 
| - void CollectReceiverTypes(unsigned ast_id, | 
| + void CollectReceiverTypes(TypeFeedbackId ast_id, | 
| Handle<String> name, | 
| Code::Flags flags, | 
| SmallMapList* types); | 
| - void SetInfo(unsigned ast_id, Object* target); | 
| + void SetInfo(TypeFeedbackId ast_id, Object* target); | 
| void BuildDictionary(Handle<Code> code); | 
| void GetRelocInfos(Handle<Code> code, ZoneList<RelocInfo>* infos); | 
| @@ -315,7 +315,7 @@ class TypeFeedbackOracle: public ZoneObject { | 
| // Returns an element from the backing store. Returns undefined if | 
| // there is no information. | 
| - Handle<Object> GetInfo(unsigned ast_id); | 
| + Handle<Object> GetInfo(TypeFeedbackId ast_id); | 
| Handle<Context> global_context_; | 
| Isolate* isolate_; |