Delay GpuCommandBufferStub::AddDestructionObserver until we need it.

Delay GpuCommandBufferStub::AddDestructionObserver until we need it.

In certain failure cases at initialization time (caused by a race) we used to call
AddDestructionObserver before we would make the surface current, causing us to
destroy the surface before OnWillDestroyStub had a chance to be called, so we
wouldn't RemoveDestructionObserver and we'd call into a dead pointer.

This fixes it. By the time MakeCurrent is called, we know we have a ref to the
surface and it won't destroy it until GpuCommandBufferStub::Destroy, after
OnWillDestroyStub is called.

BUG=140502
TEST=attach debugger to renderer, add a breakpoint to CommandBufferProxyImpl::Initialize, right-click and "view page source" (breakpoint should hit), kill new tab, and only then continue breakpoint. Observe no GPU process crash.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150227

[piman, 2012-08-06 21:59:57]

backer@ would be the most familiar person to review this, unfortunately he's out
for a little while. Since you reviewed pieces of this, would you mind taking a
look?

[piman, 2012-08-07 00:06:19]

->gman instead 'cause Al is out as well

[greggman, 2012-08-07 00:15:00]

um, lgtm

Though you're right. I probably don't have enough context to review this well.
But it looks simple enough.

[commit-bot: I haz the power, 2012-08-07 00:19:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/10831169/5001

[piman, 2012-08-07 00:20:08]

On Mon, Aug 6, 2012 at 5:15 PM, <gman@chromium.org> wrote:

> um, lgtm
>
> Though you're right. I probably don't have enough context to review this
> well.
> But it looks simple enough.
>

Thanks - I'll have backer and/or Al review when they come back.


>
>
https://chromiumcodereview.**appspot.com/10831169/<https://chromiumcodereview...
>

[commit-bot: I haz the power, 2012-08-07 01:40:34]

Change committed as 150227

[apatrick_chromium, 2012-08-09 18:47:26]

lgtm