Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2107)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/chrome_exe.gypi

Issue 10831164: CrOS: Exclude PDF crash symbol generation. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
===================================================================
--- chrome/chrome_exe.gypi (revision 149923)
+++ chrome/chrome_exe.gypi (working copy)
@@ -416,7 +416,11 @@
'../pdf/pdf.gyp:pdf',
],
'conditions': [
- ['OS=="linux" and linux_dump_symbols==1', {
+ # TODO(thestig) It would be nice to do this for CrOS as well,
+ # but when I tried that, it failed because dump_syms is built
+ # for the target arch rather than the host arch.
+ # http://crbug.com/140571
+ ['OS=="linux" and chromeos==0 and linux_dump_symbols==1', {
'dependencies': [
'../pdf/pdf.gyp:pdf_linux_symbols',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698