Issue 10831159: Fix Ash status area bubble borders

Issue 10831159: Fix Ash status area bubble borders (Closed)

Created:
8 years, 4 months ago by stevenjb

Modified:
8 years, 4 months ago

Reviewers:
jennyz

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Ash status area bubble borders BUG=137293 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149920

Patch Set 2 : Update comment #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -20 lines)			Patch
	M	ash/system/tray/system_tray_bubble.cc	View	1	4 chunks	+28 lines, -9 lines	0 comments	Download
	M	ash/system/web_notification/web_notification_tray.cc	View		5 chunks	+16 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jennyz

lgtm http://codereview.chromium.org/10831159/diff/1/ash/system/tray/system_tray_bubble.cc File ash/system/tray/system_tray_bubble.cc (right): http://codereview.chromium.org/10831159/diff/1/ash/system/tray/system_tray_bubble.cc#newcode34 ash/system/tray/system_tray_bubble.cc:34: // BubbleBorder. I am working on this item, ...

8 years, 4 months ago (2012-08-03 18:22:50 UTC) #2

stevenjb

http://codereview.chromium.org/10831159/diff/1/ash/system/tray/system_tray_bubble.cc File ash/system/tray/system_tray_bubble.cc (right): http://codereview.chromium.org/10831159/diff/1/ash/system/tray/system_tray_bubble.cc#newcode34 ash/system/tray/system_tray_bubble.cc:34: // BubbleBorder. On 2012/08/03 18:22:50, jennyz wrote: > I ...

8 years, 4 months ago (2012-08-03 19:19:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10831159/4001

8 years, 4 months ago (2012-08-03 19:21:05 UTC) #4

commit-bot: I haz the power

8 years, 4 months ago (2012-08-03 19:35:03 UTC) #5

Try job failure for 10831159-4001 (retry) on mac for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

Expand Messages | Collapse Messages