Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10831156: Fix license header for chrome/browser/resources/gaia_auth (Closed)

Created:
8 years, 4 months ago by Steve Block
Modified:
8 years, 4 months ago
Reviewers:
zel
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix license header for chrome/browser/resources/gaia_auth These files were added in https://chromiumcodereview.appspot.com/10443024 and it looks like the wrong header was used by accident. BUG=138921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/gaia_auth/offline.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/gaia_auth/test/content.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/gaia_auth/util.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Steve Block
8 years, 4 months ago (2012-08-03 15:17:23 UTC) #1
zel
lgtm
8 years, 4 months ago (2012-08-03 15:35:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/10831156/1
8 years, 4 months ago (2012-08-03 15:40:19 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 15:40:24 UTC) #4
Presubmit check for 10831156-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
See the JavaScript style guide at
http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
and if you have any feedback about the JavaScript PRESUBMIT check, contact
tbreisacher@chromium.org

** Presubmit Warnings **
Found JavaScript style violations in
chrome/browser/resources/gaia_auth/test/content.js:
  line 26: Use $('id'), from chrome://resources/js/util.js, instead of
document.getElementById('id'))
  document.getElementById('Email').value = testEmail;
  ^^^^^^^^^^^^^^^^^^^^^^^
  line 27: Use $('id'), from chrome://resources/js/util.js, instead of
document.getElementById('id'))
  document.getElementById('Passwd').value = testPassword;
  ^^^^^^^^^^^^^^^^^^^^^^^
  line 30: Use $('id'), from chrome://resources/js/util.js, instead of
document.getElementById('id'))
    document.getElementById('signIn').click();
    ^^^^^^^^^^^^^^^^^^^^^^^

Presubmit checks took 3.0s to calculate.

Powered by Google App Engine
This is Rietveld 408576698