Issue 10831155: notifications: Refactor MockBalloonView into FakeBalloonView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831155: notifications: Refactor MockBalloonView into FakeBalloonView. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

notifications: Refactor MockBalloonView into FakeBalloonView. R=atwilson@chromium.org TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150036

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -34 lines)			Patch
M	chrome/browser/notifications/desktop_notifications_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
A	chrome/browser/notifications/fake_balloon_view.h	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
A	chrome/browser/notifications/fake_balloon_view.cc	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/notification_test_util.h	View		1 chunk	+0 lines, -21 lines	0 comments	Download
M	chrome/browser/notifications/notification_test_util.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

8 years, 4 months ago (2012-08-03 19:51:05 UTC) #2

LGTM. If you are doing future notifications work, you might want to have dimich
or jianli review instead, since I believe they are the current maintainers of
that codebase.

Expand Messages | Collapse Messages