Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h

Issue 10831150: Refactor request parameters into RequestData struct. Also make RequestStage singular. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: ?? Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h
index fbbc52a6fcb1d210af716006804519c38cba1067..ca420aa0025107faf36dc1d6aa091ad92b8d36fe 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h
@@ -11,7 +11,8 @@
#include "base/basictypes.h"
#include "base/memory/linked_ptr.h"
#include "base/memory/scoped_ptr.h"
-#include "chrome/browser/extensions/api/declarative_webrequest/request_stages.h"
+#include "chrome/browser/extensions/api/declarative_webrequest/request_stage.h"
+#include "chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.h"
#include "chrome/common/extensions/api/events.h"
#include "webkit/glue/resource_type.h"
@@ -45,14 +46,13 @@ class WebRequestConditionAttribute {
const base::Value* value,
std::string* error);
- // Returns a bit vector representing extensions::RequestStages. The bit vector
+ // Returns a bit vector representing extensions::RequestStage. The bit vector
// contains a 1 for each request stage during which the condition attribute
// can be tested.
virtual int GetStages() const = 0;
// Returns whether the condition is fulfilled for this request.
- virtual bool IsFulfilled(net::URLRequest* request,
- RequestStages request_stage) = 0;
+ virtual bool IsFulfilled(const WebRequestRule::RequestData& request_data) = 0;
virtual Type GetType() const = 0;
@@ -87,8 +87,8 @@ class WebRequestConditionAttributeResourceType
// Implementation of WebRequestConditionAttribute:
virtual int GetStages() const OVERRIDE;
- virtual bool IsFulfilled(net::URLRequest* request,
- RequestStages request_stage) OVERRIDE;
+ virtual bool IsFulfilled(const WebRequestRule::RequestData& request_data)
+ OVERRIDE;
virtual Type GetType() const OVERRIDE;
private:

Powered by Google App Engine
This is Rietveld 408576698