Issue 10831137: Copy aura::Event into ui::Event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831137: Copy aura::Event into ui::Event. (Closed)

Created:
8 years, 4 months ago by Ben Goodger (Google)

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Copy aura::Event into ui::Event. http://crbug.com/125937 TEST=existing Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149888 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149916 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149954

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
A +	ui/base/event.h	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/base/event.cc	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/base/event_unittest.cc	View	1 2 3 4 5	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	ui/ui.gyp	View	1 2 3 4 5	2 chunks	+4 lines, -0 lines	0 comments	Download
M	ui/ui_unittests.gypi	View	1 2 3 4 5	3 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

This change just copies the files and gets the unit test to compile/pass. I'll replace ...

8 years, 4 months ago (2012-08-02 20:25:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/10831137/10005

8 years, 4 months ago (2012-08-03 21:57:22 UTC) #3

commit-bot: I haz the power

8 years, 4 months ago (2012-08-03 22:14:13 UTC) #4

Try job failure for 10831137-10005 (retry) on win_rel for step "runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages