Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 10831130: [Android] - Prepare apk tests for switch to checked in SDK. (Closed)

Created:
8 years, 4 months ago by Yaron
Modified:
8 years, 4 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] - Prepare apk tests for switch to checked in SDK. http://codereview.chromium.org/10830012/ contians the final patch but because this affects the WebKit build as well, it needs to be done in stages. This change introduces new gyp defines that'll be needed in WebKit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/android/envsetup_functions.sh View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yaron
8 years, 4 months ago (2012-08-02 15:12:17 UTC) #1
Peter Beverloo
LGTM. I'm just a provisional committer though, I've asked Hans to RS.
8 years, 4 months ago (2012-08-02 15:13:51 UTC) #2
hans
On 2012/08/02 15:13:51, Peter Beverloo wrote: > LGTM. > > I'm just a provisional committer ...
8 years, 4 months ago (2012-08-02 15:14:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10831130/1
8 years, 4 months ago (2012-08-02 15:15:48 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 17:05:25 UTC) #5
Change committed as 149639

Powered by Google App Engine
This is Rietveld 408576698