(Views only) Disable drop-down buttons in the website settings popup for managed permissions

(Views only) Disable drop-down buttons for managed permissions and display the source of the managed setting (e.g. policy, extension).


BUG=113688
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149981

[markusheintz_, 2012-08-02 21:24:34]

Please review this CL. Thanks a lot.

[Finnur, 2012-08-03 08:16:48]

General comments:

You probably want a TEST= line to describe to QA how to verify the change.

I would imagine you are at a point where it is starting to make sense to break
out the remaining work into more bugs that you can make this bug you referred to
(or some other) blocked on. Having 40 checkins in one bug is not ideal,
especially since the bug is very sparse and it is not clear from it what the
scope of the project is.

And with that, LGTM (with nits below).

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/app/generate...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/app/generate...
chrome/app/generated_resources.grd:227: +      <message
name="IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_USER" desc="The Website
Settings popup contains several buttons for opening dropdown menus and changing
site permissions. This is the text of such a button if the permission controlled
by the button was explicitly set to allow by the user.">
s/allow/block/

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/app/generate...
chrome/app/generated_resources.grd:233: +      <message
name="IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_DEFAULT" desc="The Website
Settings popup contains several buttons for opening dropdown menus and changing
site permissions. This is the text of such a button if the permission controlled
by the button is set to the default setting and the default settings is block">
nit: missing period at end.

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/app/generate...
chrome/app/generated_resources.grd:236: +      <message
name="IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ASK_BY_DEFAULT" desc="The Website
Settings popup contains several buttons for opening dropdown menus and changing
site permissions. This is the text of such a button if the permission controlled
by the button is set to the default setting and the default settings is ask">
Same here.

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/browser/ui/v...
File chrome/browser/ui/views/website_settings/permission_selector_view.cc
(right):

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/browser/ui/v...
chrome/browser/ui/views/website_settings/permission_selector_view.cc:95: bool
show_menu_marker);
Document the new parameter.

[markusheintz_, 2012-08-03 10:52:49]

You are right. I created bugs for tracking the individual UI implementations and
if necessary I'll also create one for the UI backend.

Lately the CL template does not include the TEST line anymore. Since there is no
test I thought I should leave it out.

I addressed all nits. 

Thanks a lot for reviewing the CL.

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/app/generate...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/app/generate...
chrome/app/generated_resources.grd:227: +      <message
name="IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_USER" desc="The Website
Settings popup contains several buttons for opening dropdown menus and changing
site permissions. This is the text of such a button if the permission controlled
by the button was explicitly set to allow by the user.">
On 2012/08/03 08:16:48, Finnur wrote:
> s/allow/block/

I already fixed that but didn't upload the patchset :( sorry.

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/app/generate...
chrome/app/generated_resources.grd:233: +      <message
name="IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_DEFAULT" desc="The Website
Settings popup contains several buttons for opening dropdown menus and changing
site permissions. This is the text of such a button if the permission controlled
by the button is set to the default setting and the default settings is block">
On 2012/08/03 08:16:48, Finnur wrote:
> nit: missing period at end.

Done.

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/app/generate...
chrome/app/generated_resources.grd:236: +      <message
name="IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ASK_BY_DEFAULT" desc="The Website
Settings popup contains several buttons for opening dropdown menus and changing
site permissions. This is the text of such a button if the permission controlled
by the button is set to the default setting and the default settings is ask">
On 2012/08/03 08:16:48, Finnur wrote:
> Same here.

Done.

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/browser/ui/v...
File chrome/browser/ui/views/website_settings/permission_selector_view.cc
(right):

https://chromiumcodereview.appspot.com/10831128/diff/5001/chrome/browser/ui/v...
chrome/browser/ui/views/website_settings/permission_selector_view.cc:95: bool
show_menu_marker);
On 2012/08/03 08:16:48, Finnur wrote:
> Document the new parameter.

Done.

[commit-bot: I haz the power, 2012-08-03 10:57:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10831128/6002

[markusheintz_, 2012-08-03 13:47:54]

Adding Robert for owners approval of the cocoa change in patchset 7.

@Robert: Patrick will do the cocoa implementation once he is back from vacation.
My change in chrome/browser/ui/cocoa/website_settings_bubble_controller.mm does
not change any existing behavior.

[Robert Sesek, 2012-08-03 14:33:20]

cocoa/ LGTM

[commit-bot: I haz the power, 2012-08-03 22:26:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10831128/13005

[commit-bot: I haz the power, 2012-08-04 00:12:56]

Change committed as 149981