Stop reflecting file operation results in wrong folders.

Stop reflecting file operation results in wrong folders.

Previusly File Manager could insert just created folder in current dir event if it acually created in another. The same thing with renaming and deleting (but that ops are harder to reproduce).

BUG=138429
TEST=Create 2 identical folders on GDrive and downloads (it's important that other to swtich to contains files with the same names). Create new folder, rename a file, delete a bunch of files on GDrive and switch to Downloads.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149628

[Vladislav Kaznacheev, 2012-08-02 12:45:39]

https://chromiumcodereview.appspot.com/10831127/diff/2001/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/directory_model.js (right):

https://chromiumcodereview.appspot.com/10831127/diff/2001/chrome/browser/reso...
chrome/browser/resources/file_manager/js/directory_model.js:514: onComplete();
Is it safe to call the callback if the directory has changed.

https://chromiumcodereview.appspot.com/10831127/diff/2001/chrome/browser/reso...
chrome/browser/resources/file_manager/js/directory_model.js:643: var
currentDirPath = this.getCurrentDirPath();
I see the pattern here. How about creating a wrapper function, something like
'callUnlessDirectoryChanged'

[SeRya, 2012-08-02 12:56:20]

https://chromiumcodereview.appspot.com/10831127/diff/2001/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/directory_model.js (right):

https://chromiumcodereview.appspot.com/10831127/diff/2001/chrome/browser/reso...
chrome/browser/resources/file_manager/js/directory_model.js:514: onComplete();
On 2012/08/02 12:45:39, Vladislav Kaznacheev wrote:
> Is it safe to call the callback if the directory has changed.

Sure. And it's called. Only fileList update is omitted in this case.

https://chromiumcodereview.appspot.com/10831127/diff/2001/chrome/browser/reso...
chrome/browser/resources/file_manager/js/directory_model.js:643: var
currentDirPath = this.getCurrentDirPath();
On 2012/08/02 12:45:39, Vladislav Kaznacheev wrote:
> I see the pattern here. How about creating a wrapper function, something like
> 'callUnlessDirectoryChanged'

In my oppinion cost of this level of abstraction doesn't cover its expenses.
It's too simple to care about reusing code.

[Vladislav Kaznacheev, 2012-08-02 13:15:13]

lgtm

[commit-bot: I haz the power, 2012-08-02 13:27:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/serya@chromium.org/10831127/2001

[commit-bot: I haz the power, 2012-08-02 15:00:34]

Change committed as 149628