test/cctest/test-regexp.cc - Issue 10831126: Take advantage of batched results when matching global regexp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-regexp.cc

Issue 10831126: Take advantage of batched results when matching global regexp. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments and formatting changes. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-regexp.cc

diff --git a/test/cctest/test-regexp.cc b/test/cctest/test-regexp.cc

index 50356e7595804ff180ca32f9baccf6715d351da9..e433b925e856f2d88cb5bd557090035812c535e8 100644

--- a/test/cctest/test-regexp.cc

+++ b/test/cctest/test-regexp.cc

@@ -267,6 +267,7 @@ TEST(Parser) {

CHECK_PARSE_EQ("\\u003z", "'u003z'");

CHECK_PARSE_EQ("foo[z]*", "(: 'foo' (# 0 - g [z]))");

+ CHECK_SIMPLE("", false);

CHECK_SIMPLE("a", true);

CHECK_SIMPLE("a|b", false);

CHECK_SIMPLE("a\\n", false);

@@ -1349,7 +1350,7 @@ TEST(MacroAssembler) {

V8::Initialize(NULL);

byte codes[1024];

RegExpMacroAssemblerIrregexp m(Vector<byte>(codes, 1024),

- Isolate::Current()->zone());

+ Isolate::Current()->runtime_zone());

// ^f(o)o.

Label fail, fail2, start;

uc16 foo_chars[3];

« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | test/mjsunit/regexp-global.js » ('j') | no next file with comments »