Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 10831123: Make incremental marking clear ICs. (Closed)

Created:
8 years, 4 months ago by Michael Starzinger
Modified:
8 years, 4 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Make incremental marking clear ICs. This extends the existing clearing of ICs during GC to incremental marking in order to prevent cross-context retention that would last until the next non-incremental GC. R=erik.corry@gmail.com TEST=cctest/test-heap/IncrementalMarkingClears[Mono,Poly]morhpicIC Committed: https://code.google.com/p/v8/source/detail?r=12259

Patch Set 1 #

Patch Set 2 : Fixed IncrementalMarkingClearsMonomorhpicIC. #

Total comments: 2

Patch Set 3 : Addressed comments by Erik Corry. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -36 lines) Patch
M src/frames.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/incremental-marking.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/mark-compact.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mark-compact.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M src/objects-visiting.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-visiting-inl.h View 1 chunk +20 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 1 chunk +145 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
8 years, 4 months ago (2012-08-02 08:21:56 UTC) #1
Erik Corry
LGTM https://chromiumcodereview.appspot.com/10831123/diff/2001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://chromiumcodereview.appspot.com/10831123/diff/2001/test/cctest/test-heap.cc#newcode2098 test/cctest/test-heap.cc:2098: TEST(IncrementalMarkingClearsMonomorhpicIC) { Should we have a test that ...
8 years, 4 months ago (2012-08-03 08:41:25 UTC) #2
Michael Starzinger
8 years, 4 months ago (2012-08-06 09:57:34 UTC) #3
Addressed comments. Landing.

https://chromiumcodereview.appspot.com/10831123/diff/2001/test/cctest/test-he...
File test/cctest/test-heap.cc (right):

https://chromiumcodereview.appspot.com/10831123/diff/2001/test/cctest/test-he...
test/cctest/test-heap.cc:2098: TEST(IncrementalMarkingClearsMonomorhpicIC) {
On 2012/08/03 08:41:25, Erik Corry wrote:
> Should we have a test that marking does _not_ clear monomorphic ICs from the
> same context?

Done.

Powered by Google App Engine
This is Rietveld 408576698