Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10831122: gdata cleanup: stop passing Profile* around GData operations. (Closed)

Created:
8 years, 4 months ago by kinaba
Modified:
8 years, 4 months ago
Reviewers:
achuithb, zel
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, kochi
Visibility:
Public.

Description

gdata cleanup: stop passing Profile* around GData operations. After http://crosbug.com/29043 is resolved, Profile* is not used in GData operations, except that GDataAuthService::Initialize (and hence indirectly GDataOperationRunner) does indeed refers to profile for OAuth2 refresh token. BUG=none TEST=existing tests (there should be no behavior change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150200

Patch Set 1 : #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -127 lines) Patch
M chrome/browser/chromeos/gdata/drive_api_operations.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_operations.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_auth_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_contacts_service.cc View 1 2 8 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_documents_service.cc View 15 chunks +11 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operations.h View 15 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operations.cc View 1 2 17 chunks +18 lines, -37 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operations_unittest.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/gdata/operations_base.h View 7 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/gdata/operations_base.cc View 6 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
Zel, could you take a look? These pointers to Profile are stored but are never ...
8 years, 4 months ago (2012-08-02 09:18:51 UTC) #1
kinaba
On 2012/08/02 09:18:51, kinaba wrote: > Zel, could you take a look? > These pointers ...
8 years, 4 months ago (2012-08-06 23:41:56 UTC) #2
achuithb
lgtm. How did you manage to get all those green trybot runs?
8 years, 4 months ago (2012-08-06 23:47:22 UTC) #3
kinaba
8 years, 4 months ago (2012-08-07 02:22:37 UTC) #4
On 2012/08/06 23:47:22, achuith.bhandarkar wrote:
> lgtm.
> 
> How did you manage to get all those green trybot runs?

The fortune is with me today :). Thanks for lgtm!

Powered by Google App Engine
This is Rietveld 408576698