Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 10831119: Cleanup - delete a pair of unneeded files. (Closed)

Created:
8 years, 4 months ago by michaeln
Modified:
8 years, 4 months ago
Reviewers:
akalin
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, tzik
Visibility:
Public.

Description

Cleanup - delete a pair of unneeded files. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149698

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -114 lines) Patch
M base/threading/sequenced_worker_pool_task_runner.h View 1 1 chunk +0 lines, -62 lines 0 comments Download
M base/threading/sequenced_worker_pool_task_runner.cc View 1 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
michaeln
hmmm... let's see if this class is actually used or not?
8 years, 4 months ago (2012-08-01 22:47:45 UTC) #1
akalin
On 2012/08/01 22:47:45, michaeln wrote: > hmmm... let's see if this class is actually used ...
8 years, 4 months ago (2012-08-01 23:04:20 UTC) #2
michaeln
I don't think this is included in any .gyp(i) files, its not in base.gypi for ...
8 years, 4 months ago (2012-08-01 23:11:45 UTC) #3
michaeln
ptal, reitveld shows these as M(odifications) but these are svn deletes. D:\src\chrome\3\src\base\threading>svn status D sequenced_worker_pool_task_runner.cc ...
8 years, 4 months ago (2012-08-01 23:47:30 UTC) #4
akalin
LGTM looks like this was supposed to be deleted by http://codereview.chromium.org/10005054
8 years, 4 months ago (2012-08-02 06:56:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/10831119/7002
8 years, 4 months ago (2012-08-02 19:02:14 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 19:02:17 UTC) #7
Presubmit check for 10831119-7002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base/threading

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698