Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 10831117: Remove ENABLE_PERSISTENT_SESSION_COOKIES (Closed)

Created:
8 years, 4 months ago by Jesse Greenwald
Modified:
8 years, 4 months ago
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org, darin-cc_chromium.org, wtc, rkn
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove ENABLE_PERSISTENT_SESSION_COOKIES This isn't needed anymore now that CookieMonster::SetPersistSessionCookies exists. BUG=115372 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149708

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -87 lines) Patch
M net/cookies/canonical_cookie.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/cookies/canonical_cookie.cc View 5 chunks +0 lines, -18 lines 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 7 chunks +0 lines, -45 lines 0 comments Download
M net/cookies/cookie_store_unittest.h View 2 chunks +0 lines, -12 lines 0 comments Download
M net/net.gyp View 1 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Iain Merrick
LGTM. CookieMonster has methods called SetForceKeepSessionState and SetPersistSessionCookies, which seem pretty redundant. Maybe we could ...
8 years, 4 months ago (2012-08-02 09:30:02 UTC) #1
erikwright (departed)
LGTM.
8 years, 4 months ago (2012-08-02 11:02:47 UTC) #2
sky
LGTM
8 years, 4 months ago (2012-08-02 16:29:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/10831117/1
8 years, 4 months ago (2012-08-02 16:38:59 UTC) #4
commit-bot: I haz the power
Failed to apply patch for net/net.gyp: While running patch -p1 --forward --force; patching file net/net.gyp ...
8 years, 4 months ago (2012-08-02 16:39:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/10831117/8001
8 years, 4 months ago (2012-08-02 17:40:10 UTC) #6
commit-bot: I haz the power
Presubmit check for 10831117-8001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-02 17:40:19 UTC) #7
Jesse Greenwald
rsleevi - can you take a look at the net/net.gyp change? Thanks,
8 years, 4 months ago (2012-08-02 17:46:59 UTC) #8
Ryan Sleevi
lgtm
8 years, 4 months ago (2012-08-02 19:16:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/10831117/8001
8 years, 4 months ago (2012-08-02 20:08:37 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 21:43:57 UTC) #11
Change committed as 149708

Powered by Google App Engine
This is Rietveld 408576698