Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: content/public/browser/web_contents.h

Issue 10831116: Move SessionStorageNamespace entirely into NavigationController and support StoragePartitions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix content shell Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index 5f65201419ce1baf4b4cc4f2476f820d61bacdf4..560315fc917c91f31c99a3d44da20356cf291857 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -10,6 +10,7 @@
#include "base/process_util.h"
#include "base/string16.h"
#include "content/common/content_export.h"
+#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/page_navigator.h"
#include "content/public/browser/save_page_type.h"
#include "content/public/browser/web_ui.h"
@@ -35,11 +36,9 @@ namespace content {
class BrowserContext;
class InterstitialPage;
-class NavigationController;
class RenderProcessHost;
class RenderViewHost;
class RenderWidgetHostView;
-class SessionStorageNamespace;
class SiteInstance;
class WebContentsDelegate;
class WebContentsView;
@@ -51,17 +50,18 @@ class WebContents : public PageNavigator {
// |base_web_contents| is used if we want to size the new WebContents's view
// based on the view of an existing WebContents. This can be NULL if not
// needed.
- //
- // The session storage namespace parameter allows multiple render views and
- // web contentses to share the same session storage (part of the WebStorage
- // spec) space. This is useful when restoring tabs, but most callers should
- // pass in NULL which will cause a new SessionStorageNamespace to be created.
CONTENT_EXPORT static WebContents* Create(
BrowserContext* browser_context,
SiteInstance* site_instance,
int routing_id,
+ const WebContents* base_web_contents);
+
+ CONTENT_EXPORT static WebContents* CreateWithSessionStorage(
Charlie Reis 2012/08/02 23:06:47 Please add a comment saying when callers should us
awong 2012/08/03 00:31:04 Done.
+ BrowserContext* browser_context,
+ SiteInstance* site_instance,
+ int routing_id,
const WebContents* base_web_contents,
- SessionStorageNamespace* session_storage_namespace);
+ const SessionStorageNamespaceMap& session_storage_namespace_map);
// Returns a WebContents that wraps the RenderViewHost, or NULL if the
// render view host's delegate isn't a WebContents.

Powered by Google App Engine
This is Rietveld 408576698