Move SessionStorageNamespace entirely into NavigationController and support StoragePartitions.

content/browser/web_contents/render_view_host_manager.cc

Index: content/browser/web_contents/render_view_host_manager.cc
diff --git a/content/browser/web_contents/render_view_host_manager.cc b/content/browser/web_contents/render_view_host_manager.cc
index 0ac69fb8bf756d455bb2c08bbb8084053cd42d74..c499d6289363a2a6f789878588a77aab2f499376 100644
--- a/content/browser/web_contents/render_view_host_manager.cc
+++ b/content/browser/web_contents/render_view_host_manager.cc
@@ -81,7 +81,8 @@ void RenderViewHostManager::Init(content::BrowserContext* browser_context,
       RenderViewHostFactory::Create(
           site_instance, render_view_delegate_, render_widget_delegate_,
           routing_id, false, delegate_->
-          GetControllerForRenderManager().GetSessionStorageNamespace()));
+          GetControllerForRenderManager().GetSessionStorageNamespace(
+              site_instance->GetProcess()->GetID())));

[Charlie Reis, 2012/08/02 23:06:47]

Are we sure we want to call GetProcess() this early?  (This will create a
process if we don't have one yet.)  Is it earlier than we used to?

[awong, 2012/08/03 00:31:04]

I bet it probably is earlier. But I don't know how else to solve this since our
principal is the child process id. I guess we could make RVH take a reference to
the controller and then request the storage namespace lazily. Would that work
better?

[Charlie Reis, 2012/08/03 22:11:28]

Looks like it's about the same time.  Before, we called it in
RenderViewHostImpl's constructor, which happens during this Create call.  So,
there's not much difference.

[awong, 2012/08/04 01:01:32]

Your instincts were right. This doesn't work because the extension service
hasn't had a chance to "observer" the creation of this object meaning that
lookup functions break.

Instead, I've reimplemented to work based on site instance.  We need to better
understand our principal for isolation, but let's move that to another CL. This
one is getting unwieldy.

 
   // Keep track of renderer processes as they start to shut down.
   registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_CLOSING,
@@ -584,7 +585,8 @@ int RenderViewHostManager::CreateRenderView(
         RenderViewHostFactory::Create(instance,
             render_view_delegate_, render_widget_delegate_, MSG_ROUTING_NONE,
             swapped_out, delegate_->
-            GetControllerForRenderManager().GetSessionStorageNamespace()));
+            GetControllerForRenderManager().GetSessionStorageNamespace(
+                instance->GetProcess()->GetID())));
 
     // If the new RVH is swapped out already, store it.  Otherwise prevent the
     // process from exiting while we're trying to navigate in it.