content/browser/dom_storage/session_storage_namespace_impl.h - Issue 10831116: Move SessionStorageNamespace entirely into NavigationController and support StoragePartitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/dom_storage/session_storage_namespace_impl.h

Issue 10831116: Move SessionStorageNamespace entirely into NavigationController and support StoragePartitions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix content shell Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_tabstrip.h ('K') | « content/browser/browser_plugin/old/browser_plugin_host.cc ('k') | content/browser/dom_storage/session_storage_namespace_impl.cc » ('j') | content/browser/web_contents/navigation_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/dom_storage/session_storage_namespace_impl.h

diff --git a/content/browser/dom_storage/session_storage_namespace_impl.h b/content/browser/dom_storage/session_storage_namespace_impl.h

index f075b546a7feae08671f84d5c3ebd6b4237c06b3..e0977083de80e041af62775fa03fc60f938eaa4d 100644

--- a/content/browser/dom_storage/session_storage_namespace_impl.h

+++ b/content/browser/dom_storage/session_storage_namespace_impl.h

@@ -16,7 +16,7 @@ namespace dom_storage {

class DomStorageSession;

}

-class SessionStorageNamespaceImpl

+class CONTENT_EXPORT SessionStorageNamespaceImpl

Charlie Reis 2012/08/02 23:06:47 Just checking: do we need this?

awong 2012/08/03 00:31:04 Yep...but only for the constructor. Moved.

: NON_EXPORTED_BASE(public content::SessionStorageNamespace) {

public:

// Constructs a |SessionStorageNamespaceImpl| and allocates new IDs for it.

@@ -38,6 +38,7 @@ class SessionStorageNamespaceImpl

virtual void SetShouldPersist(bool should_persist) OVERRIDE;

SessionStorageNamespaceImpl* Clone();

+ bool IsFromContext(DOMStorageContextImpl* context);

private:

explicit SessionStorageNamespaceImpl(dom_storage::DomStorageSession* clone);