Issue 10831112: Add a revision to V8. We do not allow blank revision in chromium's DEPS file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831112: Add a revision to V8. We do not allow blank revision in chromium's DEPS file. (Closed)

Created:
8 years, 4 months ago by Nicolas Sylvain

Modified:
8 years, 4 months ago

Reviewers:
Yang, Jakob Kummerow

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add a revision to V8. We do not allow blank revision in chromium's DEPS file. TBR=jkummerow,yangguo Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149411

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 4 months ago (2012-08-01 21:24:24 UTC) #2

LGTM.

I know that we don't want blank revisions, and it didn't happen on purpose --
the roll CL was generated by a script that worked fine many times before, but
today for some unknown reason failed to detect the proper revision to roll to. I
noticed this shortly after the roll had landed and had a CL in the CQ to fix it
[1], which unfortunately failed to apply after you landed your fix manually. I
couldn't land my own fix manually because my git checkout wasn't showing me the
revision with the broken DEPS file yet and setting up an SVN checkout would
probably have taken just as long as CQing the patch.

[1] https://chromiumcodereview.appspot.com/10824126/

I'll correct the v8_revision in the DEPS file to 12243 tomorrow when I'm back in
the office (unless someone beats me to it).

Expand Messages | Collapse Messages