- When reporting errors from the simulator framework always include the error

Improve error handling in iossim.

- When reporting errors from the simulator framework always include the error
  domain and error code since some of the strings come back from the simulator
  and those are localized.
- There appears to be a race condition where sometimes the simulator framework
  will end with an error, but the error is that the simulated app cleanly shut
  down; try to trap this error and don't fail the simulator run.

BUG=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149427

[stuartmorgan, 2012-08-01 14:26:17]

Please fix the CL description to start with a short git-friendly line (like
"Improve error handling in iossim")

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:83: // Simulator Error String Key
Explain in the comment where this comes from?

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:257: // app cleanly shut down, try trap this error and
don't fail the simulator
s/,/;/
s/try trap/try to trap/

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:264: localizedDescription, [error domain], (long)[error
code]);
C++ cast
s/long/long int/

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:267: localizedDescription, [error domain], (long)[error
code]);
Same

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:670: [error domain], (long)[error code]);
Same

[TVL, 2012-08-01 14:35:15]

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:83: // Simulator Error String Key
On 2012/08/01 14:26:17, stuartmorgan wrote:
> Explain in the comment where this comes from?

Done.

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:257: // app cleanly shut down, try trap this error and
don't fail the simulator
On 2012/08/01 14:26:17, stuartmorgan wrote:
> s/,/;/
> s/try trap/try to trap/

Done.

Also fixed in the cl description.

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:264: localizedDescription, [error domain], (long)[error
code]);
On 2012/08/01 14:26:17, stuartmorgan wrote:
> C++ cast
> s/long/long int/

Done.

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:267: localizedDescription, [error domain], (long)[error
code]);
On 2012/08/01 14:26:17, stuartmorgan wrote:
> Same

Done.

https://chromiumcodereview.appspot.com/10831111/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:670: [error domain], (long)[error code]);
On 2012/08/01 14:26:17, stuartmorgan wrote:
> Same

Done.

[stuartmorgan, 2012-08-01 15:06:58]

LGTM

[commit-bot: I haz the power, 2012-08-01 15:08:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thomasvl@chromium.org/10831111/6001

[commit-bot: I haz the power, 2012-08-01 16:42:17]

Change committed as 149427