SpeechRecognitionDispatcher: break out translation of error codes to separate function

SpeechRecognitionDispatcher: break out translation of error codes to separate function

Also remove stale comment from speech_recognition_error.h.

BUG=116954
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149612

[Satish, 2012-08-01 13:30:33]

https://chromiumcodereview.appspot.com/10831110/diff/1/content/renderer/speec...
File content/renderer/speech_recognition_dispatcher.cc (left):

https://chromiumcodereview.appspot.com/10831110/diff/1/content/renderer/speec...
content/renderer/speech_recognition_dispatcher.cc:130: // TODO(primiano):
speech_recognition_error.h must be updated to match the
is this not the intention anymore?

https://chromiumcodereview.appspot.com/10831110/diff/1/content/renderer/speec...
File content/renderer/speech_recognition_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/10831110/diff/1/content/renderer/speec...
content/renderer/speech_recognition_dispatcher.cc:138: case
content::SPEECH_RECOGNITION_ERROR_NO_MATCH:
looks like this canbeb removed (as it is handledi n line 149) and line 127's
case can be replaced with a DCHECK in line 149. The rest would be a simple
mapping so perhaps an array/table would be sufficient?

[hans, 2012-08-01 14:46:21]

https://chromiumcodereview.appspot.com/10831110/diff/1/content/renderer/speec...
File content/renderer/speech_recognition_dispatcher.cc (left):

https://chromiumcodereview.appspot.com/10831110/diff/1/content/renderer/speec...
content/renderer/speech_recognition_dispatcher.cc:130: // TODO(primiano):
speech_recognition_error.h must be updated to match the
On 2012/08/01 13:30:33, Satish wrote:
> is this not the intention anymore?

No, I think it's better that the enum in speech_recognition_error.h has the
codes that make sense for Chromium, and that we then translate to the webkit
codes like we do here.

For example, the Chromium enum has error codes for "no error" and "no match"
which are used internally, but will never be matched by error codes on the
webkit side.

https://chromiumcodereview.appspot.com/10831110/diff/1/content/renderer/speec...
File content/renderer/speech_recognition_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/10831110/diff/1/content/renderer/speec...
content/renderer/speech_recognition_dispatcher.cc:138: case
content::SPEECH_RECOGNITION_ERROR_NO_MATCH:
On 2012/08/01 13:30:33, Satish wrote:
> looks like this canbeb removed (as it is handledi n line 149) and line 127's
> case can be replaced with a DCHECK in line 149. The rest would be a simple
> mapping so perhaps an array/table would be sufficient?

The reason I kept the impossible cases (ERROR_NONE and ERROR_NO_MATCH) is to
make the switch fully cover the enum, so that if more values are added to the
enum at some point, we'll get compiler warnings about the switch not covering
them.

I don't like building look-up tables manually; the compiler should do it for us.

[Satish, 2012-08-01 15:02:38]

lgtm

[hans, 2012-08-01 15:06:14]

jam: i think your OWNERS powers cover both content/public/common/ and
content/renderer/

[jam, 2012-08-01 20:23:42]

lgtm

there are new owners in src/content btw :) please try to cycle through them

[commit-bot: I haz the power, 2012-08-02 09:12:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/10831110/1

[commit-bot: I haz the power, 2012-08-02 09:30:06]

Try job failure for 10831110-1 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-08-02 09:48:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/10831110/5

[commit-bot: I haz the power, 2012-08-02 10:07:01]

Try job failure for 10831110-5 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-08-02 10:08:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/10831110/5007

[commit-bot: I haz the power, 2012-08-02 11:32:49]

Change committed as 149612