Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 10831103: Removing usage of profile_->GetHistory() from the codebase in order to remove that function. (Closed)

Created:
8 years, 4 months ago by rpetterson
Modified:
8 years, 4 months ago
Reviewers:
dominich, sky
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Removing usage of profile_->GetHistory() from the codebase in order to remove that function. BUG=97804 TEST=existing unittests TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149583

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -23 lines) Patch
M chrome/browser/history/history_browsertest.cc View 1 2 4 chunks +16 lines, -12 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 5 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rpetterson
8 years, 4 months ago (2012-07-31 23:14:42 UTC) #1
dominich
lgtm
8 years, 4 months ago (2012-07-31 23:17:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10831103/2005
8 years, 4 months ago (2012-08-02 04:23:05 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 06:36:58 UTC) #4
Change committed as 149583

Powered by Google App Engine
This is Rietveld 408576698