Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 10831092: The peerconnection_server built target now depends on the libjingle. (Closed)

Created:
8 years, 4 months ago by Ronghua Wu (Left Chromium)
Modified:
8 years, 4 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, phoglund_chromium
Visibility:
Public.

Description

The peerconnection_server built target now depends on the libjingle. TEST=build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149254

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/libjingle/libjingle.gyp View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Ronghua Wu (Left Chromium)
8 years, 4 months ago (2012-07-31 17:01:31 UTC) #1
Sergey Ulanov
lgtm https://chromiumcodereview.appspot.com/10831092/diff/1/third_party/libjingle/libjingle.gyp File third_party/libjingle/libjingle.gyp (right): https://chromiumcodereview.appspot.com/10831092/diff/1/third_party/libjingle/libjingle.gyp#newcode651 third_party/libjingle/libjingle.gyp:651: 'libjingle', How did it work previously, without this ...
8 years, 4 months ago (2012-07-31 17:47:25 UTC) #2
Ronghua Wu (Left Chromium)
https://chromiumcodereview.appspot.com/10831092/diff/1/third_party/libjingle/libjingle.gyp File third_party/libjingle/libjingle.gyp (right): https://chromiumcodereview.appspot.com/10831092/diff/1/third_party/libjingle/libjingle.gyp#newcode651 third_party/libjingle/libjingle.gyp:651: 'libjingle', On 2012/07/31 17:47:25, sergeyu wrote: > How did ...
8 years, 4 months ago (2012-07-31 17:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/10831092/1
8 years, 4 months ago (2012-07-31 18:43:11 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 19:52:46 UTC) #5
Change committed as 149254

Powered by Google App Engine
This is Rietveld 408576698