Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 10831081: Add accelerated_video_decode as a GPU blacklist feature. (Closed)

Created:
8 years, 4 months ago by Zhenyao Mo
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add accelerated_video_decode as a GPU blacklist feature. Note that this CL does not hook the blacklist with the disabling of the feature. Will do that in another CL. BUG=139683 TEST=unit_tests TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149275

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M chrome/browser/gpu_blacklist.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gpu_blacklist_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/gpu_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gpu_util.cc View 3 chunks +11 lines, -0 lines 2 comments Download
M content/public/common/gpu_feature_type.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Zhenyao Mo
Please have a look.
8 years, 4 months ago (2012-07-30 23:35:16 UTC) #1
Ami GONE FROM CHROMIUM
LGTM % I don't know how this stuff works (wait for kbr's say-so). https://chromiumcodereview.appspot.com/10831081/diff/1/chrome/browser/gpu_util.cc File ...
8 years, 4 months ago (2012-07-30 23:38:29 UTC) #2
Zhenyao Mo
https://chromiumcodereview.appspot.com/10831081/diff/1/chrome/browser/gpu_util.cc File chrome/browser/gpu_util.cc (right): https://chromiumcodereview.appspot.com/10831081/diff/1/chrome/browser/gpu_util.cc#newcode384 chrome/browser/gpu_util.cc:384: true On 2012/07/30 23:38:29, Ami Fischman wrote: > Not ...
8 years, 4 months ago (2012-07-30 23:40:10 UTC) #3
Zhenyao Mo
Ken, please review.
8 years, 4 months ago (2012-07-31 20:17:26 UTC) #4
Ken Russell (switch to Gerrit)
8 years, 4 months ago (2012-07-31 21:09:34 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698