gdata: Get rid of callback from GDataDirectoryService::FindEntryByPath()

gdata: Get rid of callback from GDataDirectoryService::FindEntryByPath()

It didn't make sense to have a callback parameter, as this was a
synchronous function. Changed the function to return a pointer instead.
Along the way, rename the function to FindEntryByPathSync().

Replace GDataFileSystem::GetGDataEntryByPath() with FindEntryByPathSync().

BUG=137160
TEST=out/Release/unit_tests --gtest_filter=GData*  && out/Release/browser_tests --gtest_filter=GData*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149048

[achuithb, 2012-07-30 21:54:40]

Nice bit of cleanup.

lgtm

https://chromiumcodereview.appspot.com/10831076/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

https://chromiumcodereview.appspot.com/10831076/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.cc:971: if (entry)
Alternatively, you could do:
callback.Run(entry ? GDATA_FILE_OK : GDATA_FILE_ERROR_NOT_FOUND, entry);
or you could pull error out if you think that's too cryptic:
const GDataErrorCode error = entry ? GDATA_FILE_OK : GDATA_FILE_ERROR_NOT_FOUND;
callback.Run(error, entry);

[satorux1, 2012-07-30 22:10:39]

https://chromiumcodereview.appspot.com/10831076/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

https://chromiumcodereview.appspot.com/10831076/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.cc:971: if (entry)
On 2012/07/30 21:54:40, achuith.bhandarkar wrote:
> Alternatively, you could do:
> callback.Run(entry ? GDATA_FILE_OK : GDATA_FILE_ERROR_NOT_FOUND, entry);
> or you could pull error out if you think that's too cryptic:
> const GDataErrorCode error = entry ? GDATA_FILE_OK :
GDATA_FILE_ERROR_NOT_FOUND;
> callback.Run(error, entry);

Done.