Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 10831064: [cros] Remove redundant PNG enconding in UserImage. (Closed)

Created:
8 years, 4 months ago by Ivan Korotkov
Modified:
8 years, 4 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, bshe
Visibility:
Public.

Description

[cros] Remove redundant PNG enconding in UserImage. *) PNG enconding removed from UserImage. *) chrome://userimage/ source understand @<scale> spec now. BUG=137929 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149260

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -88 lines) Patch
M chrome/browser/chromeos/login/user.h View 2 chunks +6 lines, -0 lines 1 comment Download
M chrome/browser/chromeos/login/user.cc View 3 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/chromeos/login/user_image.h View 1 chunk +14 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/user_image.cc View 2 chunks +10 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/user_image_source.h View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/user_image_source.cc View 5 chunks +53 lines, -43 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ivan Korotkov
PTAL
8 years, 4 months ago (2012-07-28 02:15:57 UTC) #1
James Hawkins
lgtm
8 years, 4 months ago (2012-07-30 03:07:44 UTC) #2
Ivan Korotkov
+Biao Sorry, almost forgot to add you!
8 years, 4 months ago (2012-07-31 01:54:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10831064/1
8 years, 4 months ago (2012-07-31 01:55:02 UTC) #4
Nikita (slow)
lgtm http://codereview.chromium.org/10831064/diff/1/chrome/browser/chromeos/login/user.h File chrome/browser/chromeos/login/user.h (right): http://codereview.chromium.org/10831064/diff/1/chrome/browser/chromeos/login/user.h#newcode70 chrome/browser/chromeos/login/user.h:70: return image_index_ >= 0 && image_index_ < kDefaultImagesCount; ...
8 years, 4 months ago (2012-07-31 01:57:38 UTC) #5
Ivan Korotkov
Uh, OK, clearing commit bit.
8 years, 4 months ago (2012-07-31 01:59:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10831064/1
8 years, 4 months ago (2012-07-31 17:06:22 UTC) #7
commit-bot: I haz the power
Try job failure for 10831064-1 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-07-31 17:20:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10831064/1
8 years, 4 months ago (2012-07-31 17:55:49 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 20:15:38 UTC) #10
Change committed as 149260

Powered by Google App Engine
This is Rietveld 408576698