Issue 10831062: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831062: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed)

Created:
8 years, 4 months ago by rpetterson

Modified:
8 years, 4 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, James Su

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. BUG=112525 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149150

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -18 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_provider.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_contents_provider.cc	View		4 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/autocomplete/history_contents_provider_unittest.cc	View		3 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_tab_helper.cc	View	2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser_commands.cc	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_view_browsertest.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/10831062/diff/1/chrome/browser/ui/browser_commands.cc File chrome/browser/ui/browser_commands.cc (right): http://codereview.chromium.org/10831062/diff/1/chrome/browser/ui/browser_commands.cc#newcode564 chrome/browser/ui/browser_commands.cc:564: BookmarkModel* model = BookmarkModelFactory::GetForProfile( Nit: I would probably ...

8 years, 4 months ago (2012-07-28 00:37:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10831062/7005

8 years, 4 months ago (2012-07-31 07:36:51 UTC) #3

Change committed as 149150

Expand Messages | Collapse Messages

Issue 10831062: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages