chrome/browser/profiles/profile_manager_unittest.cc - Issue 10831061: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager_unittest.cc

Issue 10831061: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/profiles/profile_manager_unittest.cc

===================================================================

--- chrome/browser/profiles/profile_manager_unittest.cc (revision 148782)

+++ chrome/browser/profiles/profile_manager_unittest.cc (working copy)

@@ -13,6 +13,7 @@

#include "base/utf_string_conversions.h"

#include "base/values.h"

#include "build/build_config.h"

+#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/extensions/event_router_forwarder.h"

#include "chrome/browser/history/history.h"

@@ -222,9 +223,9 @@

EXPECT_TRUE(HistoryServiceFactory::GetForProfile(profile1,

Profile::EXPLICIT_ACCESS));

profile1->CreateBookmarkModel(true);

- EXPECT_TRUE(profile1->GetBookmarkModel());

+ EXPECT_TRUE(BookmarkModelFactory::GetForProfile(profile1));

profile2->CreateBookmarkModel(true);

- EXPECT_TRUE(profile2->GetBookmarkModel());

+ EXPECT_TRUE(BookmarkModelFactory::GetForProfile(profile2));

profile2->CreateHistoryService(true, false);

EXPECT_TRUE(HistoryServiceFactory::GetForProfile(profile2,

Profile::EXPLICIT_ACCESS));

« no previous file with comments | « chrome/browser/importer/profile_writer.cc ('k') | no next file » | no next file with comments »