Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 10831060: Refactor the Android port to allow access to the chrome layer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nit fixed. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
index af204ace6a6f2b7a9a74507ac3abeffcca96a0f6..8f3b2b6df01437f6340ab37e08f579bdba10a9c7 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
@@ -33,7 +33,6 @@ import java.net.URISyntaxException;
* over to WebView.
*/
public class ContentViewClient {
-
// Tag used for logging.
private static final String TAG = "ContentViewClient";
@@ -74,24 +73,6 @@ public class ContentViewClient {
public static final int ERROR_TOO_MANY_REQUESTS = -15;
@CalledByNative
- public void openNewTab(String url, boolean incognito) {
- }
-
- @CalledByNative
- public boolean addNewContents(int nativeSourceWebContents, int nativeWebContents,
- int disposition, Rect initialPosition, boolean userGesture) {
- return false;
- }
-
- @CalledByNative
- public void closeContents() {
- }
-
- @CalledByNative
- public void onUrlStarredChanged(boolean starred) {
- }
-
- @CalledByNative
public void onPageStarted(String url) {
}
@@ -100,14 +81,6 @@ public class ContentViewClient {
}
@CalledByNative
- public void onLoadStarted() {
- }
-
- @CalledByNative
- public void onLoadStopped() {
- }
-
- @CalledByNative
public void onReceivedError(int errorCode, String description, String failingUrl) {
}
@@ -115,27 +88,10 @@ public class ContentViewClient {
public void onMainFrameCommitted(String url, String baseUrl) {
}
- @CalledByNative
- public void onTabHeaderStateChanged() {
- }
-
- @CalledByNative
- public void onLoadProgressChanged(double progress) {
- }
-
public void onUpdateTitle(String title) {
}
@CalledByNative
- public void onUpdateUrl(String url) {
- }
-
- @CalledByNative
- public void onReceiveFindMatchRects(int version, float[] rect_data,
- RectF activeRect) {
- }
-
- @CalledByNative
public void onInterstitialShown() {
}
@@ -143,19 +99,9 @@ public class ContentViewClient {
public void onInterstitialHidden() {
}
- @CalledByNative
- public boolean takeFocus(boolean reverse) {
- return false;
- }
-
public void onTabCrash(int pid) {
}
- @CalledByNative
- public boolean shouldOverrideUrlLoading(String url) {
- return false;
- }
-
public boolean shouldOverrideKeyEvent(KeyEvent event) {
int keyCode = event.getKeyCode();
// We need to send almost every key to WebKit. However:
@@ -196,20 +142,6 @@ public class ContentViewClient {
public void onImeEvent() {
}
- public void onUnhandledKeyEvent(KeyEvent event) {
- // TODO(bulach): we probably want to re-inject the KeyEvent back into
- // the system. Investigate if this is at all possible.
- }
-
- @CalledByNative
- void handleKeyboardEvent(KeyEvent event) {
- onUnhandledKeyEvent(event);
- }
-
- @CalledByNative
- public void runFileChooser(FileChooserParams params) {
- }
-
// Return true if the client will handle the JS alert.
@CalledByNative
public boolean onJsAlert(String url, String Message) {

Powered by Google App Engine
This is Rietveld 408576698