Delete AppPromoLogoFetcher (dead code)

Delete AppPromoLogoFetcher (dead code)

The last reference to the class was deleted in https://chromiumcodereview.appspot.com/10539045


BUG=138614
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149235

[Gaurav, 2012-07-27 22:26:01]

Re-writing the default_apps. Thus, cleaning up dead code.

[Mihai Parparita -not on Chrome, 2012-07-29 18:17:16]

(Jon isn't working on Chrome nowadays, and I'm not sure he still wants to be
getting code reviews)

You should also include the CL issue title in the body (the body is what ends up
in the commit message, the title doesn't, so it needs to be repeated there).

https://chromiumcodereview.appspot.com/10831058/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/apps_promo.cc (right):

https://chromiumcodereview.appspot.com/10831058/diff/1/chrome/browser/extensi...
chrome/browser/extensions/apps_promo.cc:38: const int kHttpSuccess = 200;
And this constant (and kValidLogoPattern, and possibly others).

https://chromiumcodereview.appspot.com/10831058/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/apps_promo.h (left):

https://chromiumcodereview.appspot.com/10831058/diff/1/chrome/browser/extensi...
chrome/browser/extensions/apps_promo.h:14: #include
"net/url_request/url_fetcher_delegate.h"
You can also remove this include.

https://chromiumcodereview.appspot.com/10831058/diff/1/chrome/browser/extensi...
chrome/browser/extensions/apps_promo.h:20: class URLFetcher;
And this forward declaration.

[Gaurav, 2012-07-30 22:51:38]

Delete AppPromoLogoFetcher (dead code)

[Mihai Parparita -not on Chrome, 2012-07-30 23:15:50]

LGTM

[Gaurav, 2012-07-30 23:17:11]

On 2012/07/30 23:15:50, Mihai Parparita wrote:
> LGTM

Thanks Mihai

[commit-bot: I haz the power, 2012-07-30 23:17:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/10831058/4002

[commit-bot: I haz the power, 2012-07-30 23:17:24]

Presubmit check for 10831058-4002 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1257, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1105, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1022, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 476, in CheckChangeOnCommit
  File "<string>", line 381, in _CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 920, in
PanProjectChecks
    input_api, output_api, source_file_filter=None))
  File "/b/depot_tools/presubmit_canned_checks.py", line 754, in CheckOwners
    approval_needed=input_api.is_committing)
  File "/b/depot_tools/presubmit_canned_checks.py", line 792, in
_RietveldOwnerAndReviewers
    int(input_api.change.issue), True)
  File "/b/depot_tools/rietveld.py", line 88, in get_issue_properties
    return json.loads(self.get(url))
  File "/b/depot_tools/rietveld.py", line 305, in get
    return self._send(request_path, **kwargs)
  File "/b/depot_tools/rietveld.py", line 330, in _send
    result = self.rpc_server.Send(request_path, **kwargs)
  File "/b/depot_tools/third_party/upload.py", line 409, in Send
    ErrorExit(e.read())
  File "/b/depot_tools/rietveld.py", line 322, in trap_http_500
    raise urllib2.HTTPError(request_path, m.group(1), msg, None, None)
urllib2.HTTPError: HTTP Error 500: <h1>500 Server Error</h1>

[jstritar, 2012-07-31 15:38:41]

Sorry, missed this because of my email filters. LGTM!

[commit-bot: I haz the power, 2012-07-31 17:35:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/10831058/12001

[commit-bot: I haz the power, 2012-07-31 18:45:11]

Change committed as 149235