Add support for setting environment variables that are used when the simulated

Add support for setting environment variables that are used when the simulated
app is launched.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148955

[lliabraa, 2012-07-27 17:00:19]

LGTM with nits.

https://chromiumcodereview.appspot.com/10831050/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/10831050/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:386: "  -e  Specifies a environment key:value pair that
will be"
s/a/an/

https://chromiumcodereview.appspot.com/10831050/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:387: " set when the application is launched in the
simulator.\n");
I think this could be a little more clear (e.g. "...set in the simulated
application's environment") so that it's clear that the variable is set in the
app's environment, not iOS Simulator's.

https://chromiumcodereview.appspot.com/10831050/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:425: LogError(@"Invalid key=value line for -e.");
s/line/argument

[TVL, 2012-07-27 17:04:34]

https://chromiumcodereview.appspot.com/10831050/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/10831050/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:386: "  -e  Specifies a environment key:value pair that
will be"
On 2012/07/27 17:00:19, Lane LiaBraaten wrote:
> s/a/an/

Done.

https://chromiumcodereview.appspot.com/10831050/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:387: " set when the application is launched in the
simulator.\n");
On 2012/07/27 17:00:19, Lane LiaBraaten wrote:
> I think this could be a little more clear (e.g. "...set in the simulated
> application's environment") so that it's clear that the variable is set in the
> app's environment, not iOS Simulator's.

Done.

https://chromiumcodereview.appspot.com/10831050/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:425: LogError(@"Invalid key=value line for -e.");
On 2012/07/27 17:00:19, Lane LiaBraaten wrote:
> s/line/argument

Done.

[TVL, 2012-07-27 18:46:48]

adding Stuart, need a LGTM from Stuart or Rohit to cover owners.

[stuartmorgan, 2012-07-28 14:14:16]

https://chromiumcodereview.appspot.com/10831050/diff/2002/testing/iossim/ioss...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/10831050/diff/2002/testing/iossim/ioss...
testing/iossim/iossim.mm:386: "  -e  Specifies an environment key:value pair
that will be"
key=value
(so that it's not confusing what the syntax actually is)

https://chromiumcodereview.appspot.com/10831050/diff/2002/testing/iossim/ioss...
testing/iossim/iossim.mm:430: NSString* value = [envLine
substringFromIndex:(range.location + 1)];
Won't this throw an exception for |KEY=| ?

[TVL, 2012-07-30 13:00:40]

https://chromiumcodereview.appspot.com/10831050/diff/2002/testing/iossim/ioss...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/10831050/diff/2002/testing/iossim/ioss...
testing/iossim/iossim.mm:386: "  -e  Specifies an environment key:value pair
that will be"
On 2012/07/28 14:14:17, stuartmorgan wrote:
> key=value
> (so that it's not confusing what the syntax actually is)

Done.

https://chromiumcodereview.appspot.com/10831050/diff/2002/testing/iossim/ioss...
testing/iossim/iossim.mm:430: NSString* value = [envLine
substringFromIndex:(range.location + 1)];
On 2012/07/28 14:14:17, stuartmorgan wrote:
> Won't this throw an exception for |KEY=| ?

Nope, it will grab the empty string.  Docs:

"""
  anIndex
    An index. The value must lie within the bounds of the receiver, or be equal
to the length of the receiver.
"""

So it is the length case.

[stuartmorgan, 2012-07-30 13:03:01]

LGTM

[commit-bot: I haz the power, 2012-07-30 13:12:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thomasvl@chromium.org/10831050/7001

[commit-bot: I haz the power, 2012-07-30 15:15:13]

Change committed as 148955