Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 10831049: Improve constant element index access code generation (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1528 matching lines...) Expand 10 before | Expand all | Expand 10 after
1539 1539
1540 LInstruction* LChunkBuilder::DoDateField(HDateField* instr) { 1540 LInstruction* LChunkBuilder::DoDateField(HDateField* instr) {
1541 LOperand* object = UseFixed(instr->value(), r0); 1541 LOperand* object = UseFixed(instr->value(), r0);
1542 LDateField* result = 1542 LDateField* result =
1543 new(zone()) LDateField(object, FixedTemp(r1), instr->index()); 1543 new(zone()) LDateField(object, FixedTemp(r1), instr->index());
1544 return MarkAsCall(DefineFixed(result, r0), instr); 1544 return MarkAsCall(DefineFixed(result, r0), instr);
1545 } 1545 }
1546 1546
1547 1547
1548 LInstruction* LChunkBuilder::DoBoundsCheck(HBoundsCheck* instr) { 1548 LInstruction* LChunkBuilder::DoBoundsCheck(HBoundsCheck* instr) {
1549 LOperand* value = UseRegisterAtStart(instr->index()); 1549 LOperand* value = UseRegisterOrConstantAtStart(instr->index());
1550 LOperand* length = UseRegister(instr->length()); 1550 LOperand* length = UseRegister(instr->length());
1551 return AssignEnvironment(new(zone()) LBoundsCheck(value, length)); 1551 return AssignEnvironment(new(zone()) LBoundsCheck(value, length));
1552 } 1552 }
1553 1553
1554 1554
1555 LInstruction* LChunkBuilder::DoAbnormalExit(HAbnormalExit* instr) { 1555 LInstruction* LChunkBuilder::DoAbnormalExit(HAbnormalExit* instr) {
1556 // The control instruction marking the end of a block that completed 1556 // The control instruction marking the end of a block that completed
1557 // abruptly (e.g., threw an exception). There is nothing specific to do. 1557 // abruptly (e.g., threw an exception). There is nothing specific to do.
1558 return NULL; 1558 return NULL;
1559 } 1559 }
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
1831 return DefineAsRegister(new(zone()) LLoadExternalArrayPointer(input)); 1831 return DefineAsRegister(new(zone()) LLoadExternalArrayPointer(input));
1832 } 1832 }
1833 1833
1834 1834
1835 LInstruction* LChunkBuilder::DoLoadKeyedFastElement( 1835 LInstruction* LChunkBuilder::DoLoadKeyedFastElement(
1836 HLoadKeyedFastElement* instr) { 1836 HLoadKeyedFastElement* instr) {
1837 ASSERT(instr->representation().IsTagged()); 1837 ASSERT(instr->representation().IsTagged());
1838 ASSERT(instr->key()->representation().IsInteger32() || 1838 ASSERT(instr->key()->representation().IsInteger32() ||
1839 instr->key()->representation().IsTagged()); 1839 instr->key()->representation().IsTagged());
1840 LOperand* obj = UseRegisterAtStart(instr->object()); 1840 LOperand* obj = UseRegisterAtStart(instr->object());
1841 LOperand* key = UseRegisterAtStart(instr->key()); 1841 LOperand* key = UseRegisterOrConstantAtStart(instr->key());
1842 LLoadKeyedFastElement* result = new(zone()) LLoadKeyedFastElement(obj, key); 1842 LLoadKeyedFastElement* result = new(zone()) LLoadKeyedFastElement(obj, key);
1843 if (instr->RequiresHoleCheck()) AssignEnvironment(result); 1843 if (instr->RequiresHoleCheck()) AssignEnvironment(result);
1844 return DefineAsRegister(result); 1844 return DefineAsRegister(result);
1845 } 1845 }
1846 1846
1847 1847
1848 LInstruction* LChunkBuilder::DoLoadKeyedFastDoubleElement( 1848 LInstruction* LChunkBuilder::DoLoadKeyedFastDoubleElement(
1849 HLoadKeyedFastDoubleElement* instr) { 1849 HLoadKeyedFastDoubleElement* instr) {
1850 ASSERT(instr->representation().IsDouble()); 1850 ASSERT(instr->representation().IsDouble());
1851 ASSERT(instr->key()->representation().IsInteger32() || 1851 ASSERT(instr->key()->representation().IsInteger32() ||
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
2280 2280
2281 2281
2282 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2282 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2283 LOperand* object = UseRegister(instr->object()); 2283 LOperand* object = UseRegister(instr->object());
2284 LOperand* index = UseRegister(instr->index()); 2284 LOperand* index = UseRegister(instr->index());
2285 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2285 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2286 } 2286 }
2287 2287
2288 2288
2289 } } // namespace v8::internal 2289 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698