Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 10831048: Record navigations by URL scheme. (Closed)

Created:
8 years, 4 months ago by cbentzel
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Record navigations by URL scheme. BUG=139311 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148793

Patch Set 1 #

Patch Set 2 : Remove PowerSaveBlocker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
A chrome/browser/tab_contents/navigation_metrics_recorder.h View 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/browser/tab_contents/navigation_metrics_recorder.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cbentzel
It felt like a bit of overkill to add a new WebContentsObserver for this, but ...
8 years, 4 months ago (2012-07-27 10:52:23 UTC) #1
Avi (use Gerrit)
Too many? Bah. LGTM
8 years, 4 months ago (2012-07-27 14:36:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/10831048/2001
8 years, 4 months ago (2012-07-27 14:44:18 UTC) #3
commit-bot: I haz the power
Presubmit check for 10831048-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-27 14:46:15 UTC) #4
cbentzel
brettw, for chrome_browser.gypi change. avi reviewed the rest.
8 years, 4 months ago (2012-07-27 15:01:50 UTC) #5
brettw
.gypi change stubber ramp lgtm
8 years, 4 months ago (2012-07-27 17:37:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/10831048/2001
8 years, 4 months ago (2012-07-27 17:38:31 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-07-27 20:42:06 UTC) #8
Change committed as 148793

Powered by Google App Engine
This is Rietveld 408576698